<html>
<head><meta charset="utf-8"><title>automatic pings on changes to rustdoc-json-types · rustdoc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/index.html">rustdoc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/automatic.20pings.20on.20changes.20to.20rustdoc-json-types.html">automatic pings on changes to rustdoc-json-types</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="235899000"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/automatic%20pings%20on%20changes%20to%20rustdoc-json-types/near/235899000" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/automatic.20pings.20on.20changes.20to.20rustdoc-json-types.html#235899000">(Apr 23 2021 at 19:50)</a>:</h4>
<p>hey <span class="user-mention" data-user-id="319144">@CraftSpider</span> <span class="user-mention" data-user-id="268539">@Nixon Enraght-Moony</span> I'm about to add a warning when someone changes rustdoc-json-types:</p>
<div class="codehilite" data-code-language="JSON"><pre><span></span><code>        <span class="nt">"src/rustdoc-json-types"</span><span class="p">:</span> <span class="p">{</span>
          <span class="nt">"message"</span><span class="p">:</span> <span class="s2">"rustdoc-json-types is a **public** (although nightly-only) API. Consider changing `src/librustdoc/json/conversions.rs` instead."</span><span class="p">,</span>
</code></pre></div>
<p>are one of you interested in getting pinged on those changes to look at the new API? no problem if not, I can put myself as the reviewer instead</p>



<a name="235899033"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/automatic%20pings%20on%20changes%20to%20rustdoc-json-types/near/235899033" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/automatic.20pings.20on.20changes.20to.20rustdoc-json-types.html#235899033">(Apr 23 2021 at 19:51)</a>:</h4>
<p>this doesn't add anything to the whole /json folder because it would be way too noisy</p>



<a name="235922595"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/automatic%20pings%20on%20changes%20to%20rustdoc-json-types/near/235922595" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> CraftSpider <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/automatic.20pings.20on.20changes.20to.20rustdoc-json-types.html#235922595">(Apr 23 2021 at 23:20)</a>:</h4>
<p>I'd be interested in being pinged for it</p>



<a name="235922914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/automatic%20pings%20on%20changes%20to%20rustdoc-json-types/near/235922914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/automatic.20pings.20on.20changes.20to.20rustdoc-json-types.html#235922914">(Apr 23 2021 at 23:25)</a>:</h4>
<p>awesome! I'll put you down :) you don't have to be on the hook for reviewing, it's just in case someone not from rustdoc gets assigned</p>



<a name="235923283"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/automatic%20pings%20on%20changes%20to%20rustdoc-json-types/near/235923283" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/automatic.20pings.20on.20changes.20to.20rustdoc-json-types.html#235923283">(Apr 23 2021 at 23:30)</a>:</h4>
<p><a href="https://github.com/rust-lang/highfive/pull/331">https://github.com/rust-lang/highfive/pull/331</a></p>



<a name="235924982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/automatic%20pings%20on%20changes%20to%20rustdoc-json-types/near/235924982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Nixon Enraght-Moony <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/automatic.20pings.20on.20changes.20to.20rustdoc-json-types.html#235924982">(Apr 23 2021 at 23:54)</a>:</h4>
<p>Do we have a list of people using the JSON. I know of <a href="https://github.com/Maan2003/druid-rustdoc-frontend">https://github.com/Maan2003/druid-rustdoc-frontend</a>, and <span class="user-mention" data-user-id="229913">@HeroicKatora</span> has something, I think.</p>



<a name="235925412"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/266220-rustdoc/topic/automatic%20pings%20on%20changes%20to%20rustdoc-json-types/near/235925412" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/266220-rustdoc/topic/automatic.20pings.20on.20changes.20to.20rustdoc-json-types.html#235925412">(Apr 24 2021 at 00:00)</a>:</h4>
<p>that's everyone I know of</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>